fix(linter): allow undefined options in eslint plugin #27232
Merged
+175
−47
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
EslintPluginOptions is optional for the eslint crystal plugin. This change ensures the options object is checked for undefined before accessing properties closed nrwl#26556
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Skipped Deployment
|
☁️ Nx Cloud ReportCI is running/has finished running commands for commit c818e10. As they complete they will appear below. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this CI Pipeline Execution ✅ Successfully ran 4 targets
Sent with 💌 from NxCloud. |
JamesHenry
changed the title
FrozenPandaz
pushed a commit
that referenced
this pull request
Aug 1, 2024
(cherry picked from commit 0d2f76c)
|
This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
EslintPluginOptions is optional for the eslint crystal plugin. This change ensures the options object is checked for undefined before accessing properties
closed #26556
Current Behavior
If you set up the plugin with no options, you get an error when building the project graph
Expected Behavior
The plugin should allow for an empty options object since it has a default target name
Related Issue(s)
Fixes #26556